Ticket #208 (closed enhancement: fixed)

Opened 3 months ago

Last modified 2 months ago

add unit-tests and refactor the searchers

Reported by: elemoine Assigned to: elemoine
Priority: blocker Milestone: 1.0 Release
Component: Search.client Version: SVN
Keywords: Cc:
State: Commit

Attachments

patch-MapFish-208-r919-A0.diff (38.7 kB) - added by elemoine on 08/18/08 09:46:24.

Change History

08/18/08 09:46:24 changed by elemoine

  • attachment patch-MapFish-208-r919-A0.diff added.

08/18/08 09:46:35 changed by elemoine

  • state set to Review.

08/18/08 09:46:49 changed by elemoine

All unit tests pass on FF2, FF3, and IE7.

08/18/08 10:16:45 changed by sypasche

  • state changed from Review to Commit.

A few nits:

  • your prefixing some local variables with underscores, shouldn't be necessary.
  • Usually, we don't quote object properties literals.
  • some alignment issues: 
      t.ok(true, ...
       "blah blah"
       ^
       `--- should be under under the column after the opening parenthesis, not below it.

Looks fine otherwise, thanks for adding more tests.

08/18/08 11:00:08 changed by elemoine

  • status changed from new to closed.
  • resolution set to fixed.

(In [920]) dd unit-tests and refactor the searchers, r=sypasche (closes #208)

09/17/08 14:55:08 changed by elemoine

  • milestone changed from 0.3 Release to 1.0 Release.